Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Window callbacks before destroying in to avoid callback calls with invalid object. #73239

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Cleanup Window callbacks before destroying in to avoid callback calls with invalid object. #73239

merged 1 commit into from
Feb 13, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 13, 2023

Native window deletion is not instant, and some late events might arrive to the deleted Window object if callback are still set.

Fixes #72707

@bruvzg bruvzg added this to the 4.0 milestone Feb 13, 2023
@bruvzg bruvzg requested a review from a team as a code owner February 13, 2023 18:42
@bruvzg bruvzg mentioned this pull request Feb 13, 2023
Closed
@akien-mga akien-mga merged commit 854d9c3 into godotengine:master Feb 13, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the cleanup_callback branch February 13, 2023 21:08
@f8122dac91 f8122dac91 mentioned this pull request Feb 15, 2023
Closed
@Sauermann Sauermann mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Renaming Node Crashes Editor on Linux with i3wm
2 participants
@bruvzg @akien-mga