[Windows] Detect missing DLL dependencies and list them in the open_dynamic_library error message. #75383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading DLLs, Windows do not give any information which file is missing (it's always
Error 126: The specified module could not be found.). This is a constant issue for GDExtension users (a module can be broken, or miss a dependency DLL or dependency of a dependency, it is hard to determine what's wrong without using external tools like Dependency Walker).This PR adds a readable list of missing modules to the
open_dynamic_libraryerror message by recursively reading import tables of DLLs (in debug build only and if DLL loading failed).Related issues:
godotengine/godot-cpp#976
godotengine/godot-cpp#1064