-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RemoteTransform2D could fail to update AnimatableBody2D's position or rotation #75487
Fix RemoteTransform2D could fail to update AnimatableBody2D's position or rotation #75487
Conversation
dc38731
to
7c55676
Compare
…n or rotation Configure the transform per condition, and then only set it once to prevent multiple `NOTIFICATION_LOCAL_TRANSFORM_CHANGED` notifications from being sent.
7c55676
to
100b4b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say the question is why the scale was being set separately from the transform (after it) in the first place? AFAICT the reason is somehow historical: #9355 (comment). I don't see why incorporating the scale into the transform and setting just the transform (like in this PR) would be problematic.
LGTM.
I suspect godot/scene/3d/remote_transform_3d.cpp Lines 64 to 107 in c29866d
|
Maybe |
Indeed there was no Lines 589 to 683 in a2e4b80
|
Yes, for |
Configure the transform per condition, and then only set it once to prevent multiple
NOTIFICATION_LOCAL_TRANSFORM_CHANGED
notifications from being sent.Simple fix #75486.