Fix libwebp Node struct shadowing Godot's Node class in MSVC debugger #75769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedworkDE
approved these changes
May 18, 2023
akien-mga
approved these changes
May 19, 2023
|
Maybe clarify this is about webp in the commit, hard to tell what this is about by just looking at it (first assumption made me think it was about the node in Godot) Something like "Fix MSVC debugger for dev_build using webp Node for Godot" I'm not sure what the correct wording based on what's fixed would be |
akien-mga
changed the title
|
I think the commit is already ok here, but I've amended the PR title for extra clarity. |
|
Thanks! |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue when debugging on Visual Studio that sometimes the struct Node contents from libwebp quant_enc.c such as
int8_t prevwere showing up in the debugger instead of the godot Node class (for example, when clicking on the parent of Node3D to access the node's name in the debugger).This renames the struct using a
#define. it should have no effect, other than to prevent a conflicting/shadowingstruct Nodefrom showing up in the debug data.