Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Cleanup COM library initialization/uninitialization. #75881

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[Windows] Cleanup COM library initialization/uninitialization. #75881

merged 1 commit into from
Apr 18, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 10, 2023

Should fix #73039

@bruvzg bruvzg added this to the 4.1 milestone Apr 10, 2023
@clayjohn
Copy link
Member

CC @Ranoller Could you please test this PR to see if it fixes #73039 for you?

@Ranoller
Copy link
Contributor

I will try tonight and put here the results. Thanks for the work.

@Ranoller
Copy link
Contributor

It works, godot doesn´t crash on startup. Well done.
I don´t know if this can break anything, but if not, this commit is a good new to master branch. (Needed in 4+ branches but not in 3+ branches)

This should fix:
#74288
#73039
#74396
#71835 (archived but not really fixed)

@bruvzg bruvzg marked this pull request as ready for review April 13, 2023 04:31
@bruvzg bruvzg requested review from a team as code owners April 13, 2023 04:31
@akien-mga akien-mga merged commit c2edf14 into godotengine:master Apr 18, 2023
@akien-mga
Copy link
Member

Thanks!

This was referenced Apr 18, 2023
Closed
Closed
@bruvzg bruvzg deleted the win_coinit branch April 19, 2023 19:25
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

@saierXP saierXP mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Godot 4 beta versions after 7 does not launch
5 participants
@bruvzg @clayjohn @Ranoller @akien-mga @YuriSizov