Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more compression formats in Image and fix compress check #76014

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Apr 13, 2023

Check for compressing ASTC checked if the function for BPTC was present

Exposed COMPRESS_MAX to match Format

Assumed the lack of these enums was an oversight, if it was intended I will reduce this to just fixing the check

Fixes #76013

Check for compressing ASTC checked if the function for BPTC was present
@AThousandShips AThousandShips requested review from a team as code owners April 13, 2023 07:41
@AThousandShips
Copy link
Member Author

There are similar missing enums in 3.x (not ASTC though) will fix

@akien-mga akien-mga merged commit 68b8156 into godotengine:master Apr 13, 2023
@AThousandShips AThousandShips deleted the image_astc branch April 13, 2023 07:58
@AThousandShips
Copy link
Member Author

Found another error in the documentation I think, will fix that too

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C#] Image.CompressMode lacks Astc
3 participants