Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Variant for operator overloading #76244

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

kgrubbs22
Copy link
Contributor

Added unit tests in the assignment test cases for Vec4, Vec4i, Rect2, Rect2i, Trans2d, Trans3d, Color, Plane, Basis, AABB, Quant, Proj, RID, and Object as needed in #43440

@kgrubbs22 kgrubbs22 requested a review from a team as a code owner April 19, 2023 03:06
@kleonc kleonc added this to the 4.1 milestone Apr 19, 2023
@kleonc
Copy link
Member

kleonc commented Apr 19, 2023

Note that a single commit is preferred, so please squash the commits (for how-to see e.g. The interactive rebase in the docs).

…ans2d,Trans3d,Color,,Plane,Basis,AABB,Quant,Proj,RID,and Object

Updated Varaint assignemnt unit tests with Vec4,Vec4i,Rect2,Rect2i,Trans2d,Trans3d,Color,,Plane,Basis,AABB,Quant,Proj,RID,and Object

Updated Varaint assignemnt unit tests with
Vec4,Vec4i,Rect2,Rect2i,Trans2d,Trans3d,Color,,Plane,Basis,AABB,Quant,Proj,RID,and Object
@kgrubbs22 kgrubbs22 force-pushed the variant-test-updates branch from b8df71b to 0ec48a4 Compare April 19, 2023 16:27
@akien-mga akien-mga modified the milestones: 4.1, 4.2 Jun 19, 2023
@Geometror Geometror self-requested a review October 8, 2023 18:14
@akien-mga akien-mga merged commit 897ff71 into godotengine:master Oct 16, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga akien-mga changed the title Added Unit Tests for Variant for Operator Overloading Add unit tests for Variant for operator overloading Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants