[GDScript] Opportunistically elide array allocations when performing += on Array #76527
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns two bytecode operations into one by using the assignment destination directly as the output of the binary operator. This manifests in operations like `+=`.
|
Ping |
|
I can confirm this optimization works. func _ready() -> void:
await get_tree().create_timer(1).timeout
var time_start = Time.get_ticks_usec()
var a := []
for i in 6969:
a += ["element to be added 6969 times"]
var time = Time.get_ticks_usec() - time_start
var time_start2 = Time.get_ticks_usec()
var a2 := []
for i in 6969:
a2.append_array(["element to be added 6969 times"])
var time2 = Time.get_ticks_usec() - time_start2
print(time/1000.0, "ms")
print(time2/1000.0, "ms")Before: 679ms - 2.5ms No immediate regressions found. |
|
Ping |
|
Now that 4.1 has shipped, can this be reviewed? |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of the stack slot elision introduced in #76496