Fix RichTextLabel character line and paragraph index getters #76759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Tested locally (rebased against master a83eb16), it works.
Output from the MRP linked in #76758:
'T' is on line 0, paragraph 0
'h' is on line 0, paragraph 0
'i' is on line 0, paragraph 0
's' is on line 0, paragraph 0
' ' is on line 0, paragraph 0
'i' is on line 0, paragraph 0
's' is on line 0, paragraph 0
' ' is on line 0, paragraph 0
't' is on line 1, paragraph 0
'h' is on line 1, paragraph 0
'e' is on line 1, paragraph 0
' ' is on line 1, paragraph 0
'f' is on line 1, paragraph 0
'i' is on line 1, paragraph 0
'r' is on line 1, paragraph 0
's' is on line 1, paragraph 0
't' is on line 1, paragraph 0
' ' is on line 1, paragraph 0
'p' is on line 2, paragraph 0
'a' is on line 2, paragraph 0
'r' is on line 2, paragraph 0
'a' is on line 2, paragraph 0
'g' is on line 2, paragraph 0
'r' is on line 2, paragraph 0
'a' is on line 2, paragraph 0
'p' is on line 2, paragraph 0
'h' is on line 2, paragraph 0
'
' is on line 2, paragraph 0
'S' is on line 3, paragraph 1
'e' is on line 3, paragraph 1
'c' is on line 3, paragraph 1
'o' is on line 3, paragraph 1
'n' is on line 3, paragraph 1
'd' is on line 3, paragraph 1
'
' is on line 3, paragraph 1
'T' is on line 4, paragraph 2
'h' is on line 4, paragraph 2
'i' is on line 4, paragraph 2
'r' is on line 4, paragraph 2
'd' is on line 4, paragraph 2
Maybe @bruvzg wants to take a look at the logic just to make sure it's OK.
bruvzg
reviewed
Jun 22, 2023
akien-mga
added
cherrypick:4.1
|
Let's merge what we have. Thanks! But it would be great to look into the possible remaining issue and at least confirm in case it doesn't exist. |
|
@YuriSizov, sorry, I somehow missed the previous notifications. Will check and open an issue/PR if |
|
Sounds great! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix conditions for returning the character line and paragraph index for
RichTextLabel.Fixes #76758.