Fix 'linux' and specific BSD feature tags #76974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
May 11, 2023
akien-mga
approved these changes
May 12, 2023
aaronfranke
approved these changes
May 12, 2023
|
Thanks! |
bend-n
added a commit
to bend-n/godot-builds
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #76540, GDExtension's that have libraries like this are broken:
... you now have to change that to:
This also affects project settings that used the ".linux" suffix - those would also need to update to ".linuxbsd".
This PR makes the 'linux' feature tag work on Linux again, and it should also allow specific BSD tags (ex. freebsd, netbsd, etc) which were previously supported as well, but I don't personally have a way to test those.
OS.has_feature("linux")returns false on linux #76990.