Fix calculation of skinned AABB for unused bones. #77265
Conversation
lyuma
force-pushed
the
aabb_bone_lod_inside
branch
2 times, most recently
from
4de2637 to
a1c6cc6
Compare
|
Hmmm. I may have made a mistake by combining two changes here. The first fix for the AABB -1,-1,-1 works. The is_inside() check is not working. I'm still hitting cases where the incorrect LOD is used when the bounds are too large or I'm inside them. And it's very dependent on camera angle. so there's something wrong with the math here that I'm not understanding. |
Fixes bug where bounding box of 1 unit was used in some skinned models and had wrong LODs. (this could become very large if the mesh is scaled, such as FBX conversions) Also fixes a mistake in calcualting bone index.
lyuma
force-pushed
the
aabb_bone_lod_inside
branch
from
a1c6cc6 to
791d800
Compare
|
malcomnixon reported some weird LOD issues with addons/godot-xr-tools/hands/scenes/lowpoly/left_hand_low.tscn from GodotVR/godot-xr-tools, so I'm testing this right now. For now I have split it off so this just fixes the -1,-1,-1 bounding box size which we already tested. And if I figure out the other issue, I'll make a separate PR for it. |
|
Thanks! |
|
Cherry-picked for 4.0.4. While this is not a complete fix, code improvement seems good to me to include. |
Fixes bug where bounding box of 1 unit was used in some models and had wrong LODs. (this could become very large if the mesh is scaled, such as FBX conversions)
Use LOD distance of 0 if camera is inside mesh bounds, rather than distance to surface.Also fixes a mistake in calculating bone index.
This PR is part of #76184 by clayjohn
Fixes #67890
It might address part of #76436 but I have not tested MultiMesh