C#: Fix SendToScriptDebugger
crash
#77377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such a stupid error, it was so close to working correctly.
(On x64:)
The native code returned a bool as a single byte in the
al
register, leaving the rest of thea
register whatever garbage it was before, but the native to managed transition interpreted the return value as a 4 byte bool ineax
, which was mostly filled with garbage and thus not 0 (false) as intended.Somehow on dev build none of this matters and the engine just doesn't crash hiding the issue.
With this patch the return value is correctly interpreted as a single byte value on the C# side.