Increase vertical size of CurveEdit when Inspector widens
#77625
Conversation
|
@anvilfolk Would you mind rebasing this? |
There was a problem hiding this comment.
Once rebased, this can be merged.
This is indeed a problematic approach that can lead to unstable size resolution. But it works so far. If users experience issues we can always revert the change.
Also we this is okay as long as we don't expose this widget. If we do expose it, some other containers or situations can lead to our favorite infinite sizing bug. So this is something to consider, as there are a lot of requests for us to expose this.
This should allow users to edit points in a less constrained space, which feels like a UX improvement. That said, changing minimum size according to current size might be a hack that causes issues in certain situations.
|
Rebased! I am worried about the issues you have mentioned all along, since I don't have a ton of experience with editor/inspector. Let's keep an eye out for reports of slowdowns/lag when resizing the inspector with the curve editor open since that could come from this infinite/many iteration size update issue. If problems end up being significant, we can revert this and give the editor a few settings for vertical size (e.g. small, medium, large) which can be stored in the curve's metadata. The UX wouldn't be as good, but would be more likely to avoid these issues! I am glad we are giving this a try since it does make a difference when working with the curve editor :) |
|
Thanks! |
This should allow users to edit points in a less constrained space, which feels like a UX improvement.
That said, per @YuriSizov, changing minimum size according to current size might be a hack that causes issues in certain situations, so there's a good chance this shouldn't be accepted :)
Also: known issue that if you open the curve editor then maximize the entire editor window, this does not appear to take effect until you actually resize the inspector tab. Possibly a symptom of the above issue?