-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement loading OGG files from buffer and file path #78084
Conversation
4b602d1
to
7ddf2e6
Compare
90c6754
to
b0b7c39
Compare
b0b7c39
to
fbceb80
Compare
ad87586
to
43d85fd
Compare
Legend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some style comments, but the implementation looks ok.
I will be slow modifying this. |
43d85fd
to
1f5d51d
Compare
|
Could be |
@fire Any chance you could update this soon? |
Will update soon. |
7d1e51a
to
10b6011
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7c12dcf
to
edcec53
Compare
edcec53
to
e391eae
Compare
Thanks! |
@YuriSizov Should we expect this to be featured in 4.1.2? |
@Overvault-64 You should expect this in 4.2. We normally don't include new features in maintenances releases (4.1.x). |
Remake of #68540
Test Plan:
Tested that ordinary OGGs load.
Load from buffer needs testing.
Assistance Log
audio-coding.md
Production edit: Closes #61091