Update the edited script resource only on save #78159
Draft
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the script editor will update the cached script resource directly when the code idle timeout expires. This means an unsaved script can affect other aspects of the editor, leading to some issues (#50578, #78126). This is also quite surprising to me personally, as I would expect my changes to take effect only when I save the script, in line with an external code editor. To follow the principle of least surprise, I think this needs to be changed.
This PR (currently draft), changes the behaviour to only update the script resource when it is actually saved to disk. This fixes #50578 and fixes #78126.