Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of vformat() with no placeholders #78797

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Remove uses of vformat() with no placeholders #78797

merged 1 commit into from
Jul 8, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 28, 2023

This is identical to passing the string directly.

Regexes used:

vformat\("[a-z0-9_%\-!?:;, ]+"\)
vformat\("[^,]+"\) (some false positives)

@Calinou
Remove uses of vformat() with no placeholders
dcc92c1 
This is identical to passing the string directly.
@Calinou Calinou requested review from a team as code owners June 28, 2023 14:28
@Calinou Calinou added enhancement topic:codestyle cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jun 28, 2023
@Calinou Calinou added this to the 4.x milestone Jun 28, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jun 28, 2023
@akien-mga akien-mga merged commit 43c0fa7 into godotengine:master Jul 8, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @YuriSizov