Initialize particles instance buffer in case it is used before being updated #78852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #71935
We have two buffers that we use for particles:
The particles instance buffer is usually filled right after rendering the particles, but when using the "view depth' draw order, or when using billboarding the instance buffer is filled during the scene culling stage (so the camera is known).
This causes problems as particles can get updated late in the frame that they were just allocated (which is the problem that #70418 solved, but only partially).
The bug here comes from relying on unitialized memory (i.e. instance buffer gets created but isn't filled), so the solution is simply to initialize the memory to 0. This way the particles won't draw until ready. Alternative solutions that are less robust are: