-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement scene change #78988
Merged
Merged
Reimplement scene change #78988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title says "Avoid too early removal of current scene", but you've moved it to an even earlier point, kinda 🤔 I don't think |
RandomShaper
added
the
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
label
Jul 4, 2023
RandomShaper
force-pushed
the
fix_change_scene
branch
from
July 4, 2023 11:28
bf04c92
to
6538769
Compare
RandomShaper
changed the title
Avoid too early removal of current scene in change_scene()
Reimplement scene change
Jul 4, 2023
RandomShaper
force-pushed
the
fix_change_scene
branch
from
July 4, 2023 11:29
6538769
to
4354cd8
Compare
I've changed the PR to a new approach. |
YuriSizov
reviewed
Jul 4, 2023
This was referenced Jul 11, 2023
This one would be good for 4.2 dev builds. |
YuriSizov
approved these changes
Jul 26, 2023
Thanks! |
This was referenced Nov 22, 2023
Closed
YuriSizov
removed
the
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
label
Jan 23, 2024
Given the changes in behavior, we shouldn't cherry-pick this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes #78788.
Maybe fixes #70910.
Bugsquad edit: