Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement scene change #78988

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Jul 3, 2023

Maybe fixes #78788.
Maybe fixes #70910.

Bugsquad edit:

@RandomShaper RandomShaper added this to the 4.2 milestone Jul 3, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner July 3, 2023 16:11
@YuriSizov
Copy link
Contributor

The title says "Avoid too early removal of current scene", but you've moved it to an even earlier point, kinda 🤔 I don't think queue_freeing it would be sufficient. I think we also need to unparent the node first, so we stop processing.

@RandomShaper RandomShaper marked this pull request as draft July 3, 2023 16:17
@RandomShaper RandomShaper added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 4, 2023
@RandomShaper RandomShaper changed the title Avoid too early removal of current scene in change_scene() Reimplement scene change Jul 4, 2023
@RandomShaper
Copy link
Member Author

I've changed the PR to a new approach.

@RandomShaper RandomShaper marked this pull request as ready for review July 4, 2023 11:30
@RandomShaper RandomShaper requested a review from a team as a code owner July 4, 2023 11:30
@RandomShaper
Copy link
Member Author

This one would be good for 4.2 dev builds.

@YuriSizov YuriSizov merged commit e8df8c5 into godotengine:master Jul 26, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Given the changes in behavior, we shouldn't cherry-pick this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants