Fix byte to float color conversion in DisplayServerWindows::screen_get_pixel
#79350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
255
should be mapped to1.0
, it was mapped to255.0 / 256.0
.byte / 255.0
is how we convert in most places I think (e.g. inColor
orImage
).Fixes #79348.
No incorrect conversion spotted for Linux / MacOS:
godot/platform/linuxbsd/x11/display_server_x11.cpp
Line 1220 in 23318e8
godot/platform/macos/display_server_macos.mm
Lines 2226 to 2228 in 23318e8