Change 2D navigation ProjectSettings from integers to floats #79483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
added
bug
topic:navigation
topic:2d
cherrypick:4.0
cherrypick:4.1
mohe2015
reviewed
Jul 14, 2023
Changes 2D navigation ProjectSettings from integers to floats.
smix8
force-pushed
the
nav2d_pj_props_4.x
branch
from
cd0b3d3
to
2852fb4
Compare
Forgot to build the ProjectSettings xml. Will only work for new projects or projects that have not changed the defaults. If an existing project has already changed the ProjectSettings the value will need to be reset first. |
Scony
approved these changes
Jul 15, 2023
YuriSizov
approved these changes
Jul 18, 2023
YuriSizov
removed
the
cherrypick:4.1
This doesn't make it a good candidate for cherry-picking then. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 2D navigation ProjectSettings from integers to floats.
Related issue #79474.
That was some arbitrary limitation added just for the ProjectSettings considering that those properties are floats everywhere else.