Clarify the purpose of RichTextLabel text highlight padding #79571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Calinou
commented
Jul 17, 2023
Calinou
commented
- This closes RichTextLabel text padding options do not affect highlighted text #79534.
Calinou
added
enhancement
documentation
cherrypick:4.0
cherrypick:4.1
YuriSizov
reviewed
Oct 30, 2023
| @@ -706,10 +706,10 @@ | |||
| The vertical separation of elements in a table. | |||
| </theme_item> | |||
| <theme_item name="text_highlight_h_padding" data_type="constant" type="int" default="3"> | |||
| The horizontal padding around a highlighting and background color box. | |||
| The horizontal padding around boxes drawn by the [code][fgcolor][/code] and [code][bgcolor][/code] tags. This does not affect the appearance of text selection. | |||
There was a problem hiding this comment.
Suggested change
| The horizontal padding around boxes drawn by the [code][fgcolor][/code] and [code][bgcolor][/code] tags. This does not affect the appearance of text selection. | |
| The horizontal padding around boxes drawn by the [code skip-lint][fgcolor][/code] and [code skip-lint][bgcolor][/code] tags. This does not affect the appearance of text selection. |
YuriSizov
reviewed
Oct 30, 2023
| </theme_item> | ||
| <theme_item name="text_highlight_v_padding" data_type="constant" type="int" default="3"> | ||
| The vertical padding around a highlighting and background color box. | ||
| The vertical padding around boxes drawn by the [code][fgcolor][/code] and [code][bgcolor][/code] tags. This does not affect the appearance of text selection. |
There was a problem hiding this comment.
Suggested change
| The vertical padding around boxes drawn by the [code][fgcolor][/code] and [code][bgcolor][/code] tags. This does not affect the appearance of text selection. | |
| The vertical padding around boxes drawn by the [code skip-lint][fgcolor][/code] and [code skip-lint][bgcolor][/code] tags. This does not affect the appearance of text selection. |
YuriSizov
approved these changes
Oct 30, 2023
YuriSizov
removed
cherrypick:4.0
cherrypick:4.1
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.