Add export_preserialize to the GLTF export process
#79623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
gltf-export-preserialize
branch
from
63301f7 to
68c845b
Compare
aaronfranke
force-pushed
the
gltf-export-preserialize
branch
from
68c845b to
e8906b5
Compare
lyuma
approved these changes
Aug 2, 2023
akien-mga
changed the title
export_preserialize to the GLTF export process
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new extension hook to the GLTF export process,
_export_preserialize. This runs each time we serialize to a buffer or file. This allows extension authors to alter the data between converting Godot nodes to the state data, and converting the state data to JSON. This is also the earliest opportunity to read the destination file name and path.