Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when the changed signal is emitted for Resource and Material #79656

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

josefalanga
Copy link
Contributor

@josefalanga josefalanga commented Jul 19, 2023

@josefalanga josefalanga requested a review from a team as a code owner July 19, 2023 12:11
@YeldhamDev YeldhamDev added this to the 4.2 milestone Jul 19, 2023
doc/classes/Material.xml Outdated Show resolved Hide resolved
doc/classes/Material.xml Outdated Show resolved Hide resolved
doc/classes/Material.xml Outdated Show resolved Hide resolved
@YuriSizov YuriSizov changed the title Update docs of Resource and Material classes Clarify when the changed signal is emitted for Resource and Material Jul 21, 2023
@YuriSizov
Copy link
Contributor

Could you also please squash your commits into one? Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing.

@YuriSizov YuriSizov merged commit 9199649 into godotengine:master Jul 24, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks! And congrats on your first merged Godot pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Materials do not fire changed signal when any of its properties change
5 participants