Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Manager navigation improve #79746

Conversation

gamedevishard
Copy link
Contributor

@gamedevishard gamedevishard commented Jul 21, 2023

At the moment, keyboard navigation in the godot project manager is not intuitive. I tried to improve it
project_manager

Also, Buttons not related to local projects have moved to the top.
Before:
before2

After:
After

@AThousandShips
Copy link
Member

AThousandShips commented Jul 21, 2023

Something pretty similar is already done in #50674

This requires a proposal to discuss the details and reasons for making this change, please open one, or this will likely not be accepted

Though I'd argue this is a duplicate of the already existing change and you should discuss the details on that PR instead, as the changes here are almost identical to those in that PR

@AThousandShips
Copy link
Member

AThousandShips commented Jul 21, 2023

I'd also suggest making a clean screenshot in an unmodified version of 4.2, to make sure the exact differences are clear (as it looks currently like the "before" has more contrast and more clear text)

But I'd suggest writing on the other PR and see if the original PR is still active and if the contributor is able to work on it and rebase it, otherwise it can be considered dead and be replaced, otherwise I'd say it should be given preference as it was there first

@gamedevishard
Copy link
Contributor Author

I'd also suggest making a clean screenshot in an unmodified version of 4.2, to make sure the exact differences are clear (as it looks currently like the "before" has more contrast and more clear text)

I have updated the screenshot

@seppoday
Copy link

seppoday commented Jul 21, 2023

shameless plug, kinda related to that changes: #74561 (comment)

@AThousandShips
Copy link
Member

Pinged the other PR and checked if they can rebase and update theirs, and suggested the two of you coordinate, and we'll see if they respond

I have some feedback ideas but I'll wait to see where we go between these two first, to spare everyone more work

@AThousandShips AThousandShips added this to the 4.x milestone Jul 21, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Jul 31, 2023

Closing as #50674 was merged, doing mostly the same thing

Thank you for contributing nonetheless

@AThousandShips AThousandShips removed this from the 4.x milestone Jul 31, 2023
@starry-abyss
Copy link
Contributor

And what's about keyboard navigation? I haven't touched it in that my PR.

@YuriSizov
Copy link
Contributor

Improvements to keyboard navigation are welcome, though they should have been done as a separate PR anyway. So right now, a new PR focused on that should be made against the current master on top of your changes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants