Remove spaces from input of HTML color in color picker #79782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
approved these changes
Jul 23, 2023
Calinou
approved these changes
Jul 23, 2023
|
Thanks! And congrats on your first merged Godot pull request! |
|
Thank your very much, it was a great experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color picker is now much more liberal about the user input, and simply removes the spaces before passing the string for further processing. This is especially useful when copy-pasting HTML color codes from color palettes, as there is always the chance of accidentally copying some spaces as well. Having to remove them manually is quite tedious and not as intuitive as it could be.
Accepting valid HTML color codes with spaces is also the default behavior of programs with similar color picker functionality such as Affinity Designer, Blender, or Gimp.
Fixes #79338