Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add path to built-in scripts #79920

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 26, 2023

Freshly created built-in scripts don't have a path. They show as [unsaved] and can't be saved using the save script shortcut (this is especially prominent after #79337)

This PR adds an default path to newly created scripts, so they can be recognized as part of the scene.

Before:

godot_wWAlceX3fC.mp4

After:

godot.windows.editor.dev.x86_64_FRIqqPkG8A.mp4

@KoBeWi KoBeWi added this to the 4.x milestone Jul 26, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner July 26, 2023 12:55
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 13, 2023
@YuriSizov YuriSizov merged commit 9948f03 into godotengine:master Sep 14, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@KoBeWi KoBeWi deleted the most_sane_path branch September 14, 2023 13:33
@YuriSizov YuriSizov added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants