-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ThorVG to v0.10.0 #80095
Update ThorVG to v0.10.0 #80095
Conversation
Not for this pr, but lottie support is in thorvg v0.10.0! https://github.com/thorvg/thorvg/releases/tag/v0.10.0 For a future date, we can rasterize lottie like svg and to sprite animation for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have intentionally touched the old configuration minimally and haven't found any regression so far. I want to modify the current installation (make it clearer) by copying only the parts that are currently used in Godot (+ corresponding modification of the scons files). The next version will improve and change the file structures, and the required scons changes would then be more understandable and this also reduces the Godot binary size. I would prefer make that in another PR. Or should I make the changes directly in this PR? |
Would this reduce the number of files included? If so, this would definitely be worth doing now, because extra 24k LOC is problematic. |
Hey, thanks for the PR! |
Yes, I copied only the minimum what Godot needs. I had some time now :) to take a closer look at the Godot's svg scons files. IMO the original authors made a mistake to additionally enabling ThorVG parts that are completely useless in the current Godot implementation. After some internal tests, I will then update the PR to review the changes... |
As I said ^above^, please read the comments for this release and see in the ThorVG issues. There are some additional svg feature or speed improvements. At least I hope @MewPurPur can now further increase his excellent icon creativity with my contribution:) |
04ee9e2
to
2216409
Compare
- Release Notes: https://github.com/thorvg/thorvg/releases/tag/v0.10.0 - API change ARGB8888_STRAIGHT -> ARGB8888S - SVG-SCsub: Enable static ThorVG object linking - SVG-SCsub: avoid building unused ThorVG parts - update-thorvg.sh: add v0.10.0 and copy only the Godot relevant code
2216409
to
ac9e259
Compare
OK. I rebased the PR to the current Github tip, loaded about 2k SVG images, tested some SVG fonts and didn't found a regression to the timing based thread-deadlock issues that are already present in 4.2. But all our projects are running in the |
I'm looking forward to Godot supporting Lottie animations on the user side. If you need any assistance with playing Lottie animations in Godot, please don't hesitate to reach out. Thank you! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks! |
I'm seeing these linker warnings on Windows with MSVC:
Compiling with CC @bruvzg as it involves Edit: Fixed in #80713. |
…t-servers SCons: Fix ThorVG build option in TextServers with #80095
For more information please read the release notes: https://github.com/thorvg/thorvg/releases/tag/v0.10.0
SVG: