-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PathFollow3D update issues #80233
Fix PathFollow3D update issues #80233
Conversation
Could you provide a test project that you've used to verify the fixes? Also, could you please amend the first line of the commit message to be a bit more explicit (the title of the PR is fine for that). |
86dd781
to
94e58f2
Compare
I found the problems when try to revamp this PR #68873 The test file uploaded by @Calinou at the end is used.
Sure, changed. |
@YuriSizov Hi, any chance to have this PR reviewed recently? It is relatively simple, and will significantly improve the user experience of this PR #80329 |
35a3d45
to
3573419
Compare
3573419
to
fd87e34
Compare
fd87e34
to
7d59652
Compare
7d59652
to
704aad0
Compare
704aad0
to
bfdbe86
Compare
Other than what I mentioned above code looks fine and changes seem sensible. @aaronfranke @kleonc Could you check the math, do these changes to transform updates make sense? |
dacdfd5
to
b40c6a4
Compare
- transform is not updated after setting new flags such as `use_model_front` - transform is not updated when the parent Path3D changes - correct_posture() behaves differently when assuming model front - _update_transform() was in immediate mode, could leads to chained calls on scene instantiation.
b40c6a4
to
43b184b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Note this should not be cherry-picked to 4.2 on its own because of a regression: #95612. |
This PR fix the following minor issues on PathFollow3D.
use_model_front
Before:
Screen.Recording.2023-08-07.at.15.08.10.mov
After:
Screen.Recording.2023-08-07.at.15.23.11.mov