-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Redesign MSBuild panel #80260
C#: Redesign MSBuild panel #80260
Conversation
71283fb
to
ad38399
Compare
This can now be finished on top of #80227. Would love to have this in 4.2 🙂 |
ad38399
to
32f521b
Compare
modules/mono/editor/GodotTools/GodotTools/Build/BuildOutputView.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/GodotTools/GodotTools/Build/BuildProblemsView.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/GodotTools/GodotTools/Build/MSBuildPanel.cs
Outdated
Show resolved
Hide resolved
ec42a9f
to
c64981c
Compare
hbTools2.AddChild(_toggleLayoutButton); | ||
|
||
// Show Search. | ||
_showSearchButton = new Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to replace Flat = true
with theme type variation FlatButton
, so it has a nice pressed state.
I also noticed that you have a couple of your own dialogs, including an error dialog. First of all, you could use (Also there is this strange error that I got from creating a new C# script in the editor, it throws trying to call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are pretty minor problems, overall it all seems very nice!
- Redesign panel to look closer to the look of other Godot panels such as Output and Debugger. - Moved list of problems and output log to separate tabs instead of using a HSplit. - Added Tree/List layouts to the problems tab. - Added search box to filter problems tab. - Added `FileTree` icon, made from `FileList`. Both are used for the button that toggles the Tree/List layouts.
c64981c
to
f19694a
Compare
I tried using |
Thanks! |
That's weird. Make sure you don't parent it manually to anything, the popup methods handles that. |
@YuriSizov It seems it's because of |
TabBar
of aTabContainer
#80227 or Allow adding buttons to theTabContainer
header #80301.FileTree
icon, made fromFileList
. Both are used for the button that toggles the Tree/List layouts.