-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify SceneTree.current_scene
functionality
#80264
Conversation
Thanks for opening a PR! Why does your edit basically repeat the same thing twice? |
I wanted to emphasize the fact of getting the top node quickly, something not as simple as it seems. Even using |
Notes should be used for important but tangential mentions. Here you can just continue the paragraph with an extra tip. |
It's ok now. |
You should rebase instead of merging into your branch, you will need to clean up your branch |
See here, do not merge like this |
What you need to do is:
|
SceneTree.current_scene
functionality.
Please squash your commits into a single commit as described above |
I fixed it. Need to squash, I think. |
Are you using |
I believe it is fixed now. Thanks. |
SceneTree.current_scene
functionality.SceneTree.current_scene
functionality
Unfortunately, not exactly. You had your branch name as your commit message. I fixed it and pushed on your behalf, so it should be good now. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Improving the
current_scene
description, which was always very succinct. Now it clearly expresses the possibility of quickly getting the top node of the currently running scene.This change is compatible with
3.x
. (Bugsquad edit, needs modifications for the names of the methods for changing scene)