Add helper for 3D gizmos and unify box

[KoBeWi]

Follow-up to #71092
Closes godotengine/godot-proposals#5019

I added a new class similar to ViewPanner and modified every box gizmo I knew about.

godot.windows.editor.dev.x86_64_wug876f0K6.mp4

We could do the same refactor for other shapes too. The code duplication is huge.

[KoBeWi]

Not sure about the value here. Some gizmos used 16k, but not all. Doesn't seem to affect editing, but maybe it's noticeable on very big scales, idk. It could be a parameter.

[fire]

Anything bad with defaulting to 16k?

[KoBeWi]

No idea, hence I'm asking. I could change it to 16k.

[fire]

Wow, this is amazing. I'll check in later when the tests pass.

[KoBeWi]

Unfortunately I have no idea why the checks fail.

[AThousandShips]

Making the destructors of the classes using the helper seems to make the problem go away, I suspect it is due to compilation order, and that the first time the class destructor is referenced it is defined, causing problems if it is requested in a context where the include isn't present, the least invasive fix would be to add the constructors, haven't tested but compiling editor/plugins/gizmos before the editor/plugins might work as well

Edit: confirmed, this solves the compilation, will look into doing a PR to make this behaviour not context dependent across the engine

[AThousandShips]

CollisionShape3DGizmoPlugin and CSGShape3DGizmoPlugin also need these

[KoBeWi]

It does not make any sense, but it seems to have helped.
Thanks for looking into it.

[AThousandShips]

Looking into an alternative fix, general instead and unrelated to this PR, it's currently compiling, will see if it works

[KoBeWi]

I think an alternative fix might be including gizmo helper in Node3D editor plugin.

compiling editor/plugins/gizmos before the editor/plugins might work as well

Order is enforced by formatting.

[AThousandShips]

I meant in the SCsub

My alternative fix unfortunately didn't work so will look at other cases to prevent the context dependent issue, ensuring that you don't run into a hard to diagnose error by having the result depend on which source is compiled first, so I'd say to keep the explicit destructors here

[akien-mga]

Looks good to me, though I didn't test. Might be worth rebasing.

[Calinou]

Tested locally, it mostly works as expected. I noticed one issue related to this PR:

• Decal does not use the new handler for resizing only one size, so it always behaves as if Alt as held down.

ReflectionProbe, VoxelGI and CSGBox3D all behave as expected.

Gizmo handle icons are also broken, but this also occurs in master:

[KoBeWi]

Modified decal editor.

[akien-mga]

In file included from ./core/io/file_access.h:36,
                 from ./core/io/config_file.h:34,
                 from ./editor/editor_plugin.h:34,
                 from editor/plugins/node_3d_editor_plugin.h:34,
                 from editor/plugins/node_3d_editor_plugin.cpp:31:
./core/object/ref_counted.h: In instantiation of 'void Ref<T>::unref() [with T = Gizmo3DHelper]':
./core/object/ref_counted.h:222:3:   required from 'Ref<T>::~Ref() [with T = Gizmo3DHelper]'
./editor/plugins/gizmos/decal_gizmo_plugin.h:38:7:   required from 'void memdelete(T*) [with T = DecalGizmoPlugin]'
./core/object/ref_counted.h:210:13:   required from 'void Ref<T>::unref() [with T = DecalGizmoPlugin]'
./core/object/ref_counted.h:222:3:   required from 'Ref<T>::~Ref() [with T = DecalGizmoPlugin]'
editor/plugins/node_3d_editor_plugin.cpp:7938:65:   required from here
Error: ./core/object/ref_counted.h:209:31: error: invalid use of incomplete type 'class Gizmo3DHelper'
  209 |   if (reference && reference->unreference()) {
      |                    ~~~~~~~~~~~^~~~~~~~~~~
In file included from editor/plugins/node_3d_editor_plugin.cpp:52:
./editor/plugins/gizmos/collision_shape_3d_gizmo_plugin.h:36:7: note: forward declaration of 'class Gizmo3DHelper'
   36 | class Gizmo3DHelper;
      |       ^~~~~~~~~~~~~

[Calinou]

Modified decal editor.

Works great now 🙂

[YuriSizov]

Thanks!

PS. Maybe for side handles we want a different icon? Like a similarly styled square instead of a circle?

[jcostello]

@KoBeWi is it posible to make it work so the center of the node doesn't change when moving the gizmos? If so I can create a proposal. For things like Reflection Probes could be helpful so the offset and the center dont move when moving the gizmo

[KoBeWi]

When you hold Alt while resizing the node stays in place.

[jcostello]

@KoBeWi but both size resize evenly. Im talking about one side at the time

[KoBeWi]

Eh I think I don't understand. You can open a proposal about it I guess and explain in details.
You can't move one side without moving the center (not sure about reflection probe, I think it had double gizmo).

[jcostello]

@KoBeWi godotengine/godot-proposals#7889