Fix issue with four subpasses always been requested in mobile renderer #80368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
added
bug
topic:rendering
topic:3d
cherrypick:4.1
|
cc @Calinou (sorry I forgot looking at this earlier, was an easy fix) |
|
Not sure what to make of the CI error |
clayjohn
approved these changes
Aug 8, 2023
|
Thanks! |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little bit of history, originally we didn't communicate our scaling settings to the render implementation (just wasn't communicated) so we allowed
get_color_fbsto silently fail early on if the size of the 3D render buffer differed from our render target.If it failed we simply fell back to our 3 subpass + 1 normal pass approach.
Then we did a rework of the scaling logic and did pass this information. We can see in
_render_scenewe are now properly checking(rb->get_scaling_3d_mode() != RS::VIEWPORT_SCALING_3D_MODE_OFF)and we removed the silent fail fromget_color_fbshowever I omitted to change the logic that always attempted to retrieve the 4 sub-pass framebuffer.This PR changes that.
Fixes #70093