Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DisplayServer] Add method to estimate window title bar size. #80409

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[DisplayServer] Add method to estimate window title bar size. #80409

merged 1 commit into from
Oct 3, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 8, 2023 •
edited
Loading

Adds a DisplayServer.window_get_title_size(String title, WindowID window) method to estimate window title size (size of the window control buttons and title string using system font).

Implemented on macOS and Windows.

Fixes #80310

@bruvzg bruvzg added this to the 4.x milestone Aug 8, 2023
@bruvzg bruvzg mentioned this pull request Aug 8, 2023
Closed
@bruvzg bruvzg force-pushed the est_title_size branch 3 times, most recently from 9e47133 to f303417 Compare August 14, 2023 09:16
@bruvzg bruvzg marked this pull request as ready for review September 4, 2023 06:53
@bruvzg bruvzg requested review from a team as code owners September 4, 2023 06:54
@KoBeWi
Copy link
Member

KoBeWi commented Oct 2, 2023 •
edited
Loading

This is the minimum width of the delete dialog:
image
The space between text and buttons seems slightly too big. Though it's an estimate, so probably can't be improved much I assume?

EDIT:
Custom dialog for comparison:
image
This spacing looks alright.

KoBeWi
KoBeWi reviewed Oct 2, 2023
View reviewed changes
scene/main/window.cpp Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Oct 2, 2023
View reviewed changes
scene/main/window.h Outdated Show resolved Hide resolved
KoBeWi
KoBeWi reviewed Oct 2, 2023
View reviewed changes
doc/classes/Window.xml Outdated Show resolved Hide resolved
KoBeWi
KoBeWi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say much about the platform-specific code, but it works correctly.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 3, 2023
akien-mga
akien-mga approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc changes to make, otherwise seems good.

@akien-mga akien-mga merged commit 530e01b into godotengine:master Oct 3, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov mentioned this pull request Nov 24, 2023
Merged
@akien-mga akien-mga mentioned this pull request Dec 5, 2023
Closed
@Calinou Calinou mentioned this pull request Jun 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos platform:windows topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Modal Dialogs' Auto-Size Behavior Should Include the Nonclient Area (Caption Text)
3 participants
@bruvzg @KoBeWi @akien-mga