Editor: Improve Signal Dock for script classes #80411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add signal documentation for script classes. * Use separate sections for script class inheritance.
dalexeev
force-pushed
the
editor-improve-signal-dock
branch
from
206be5d to
1d5539c
Compare
dalexeev
commented
Aug 16, 2023
| } | ||
| descr_cache[base][signal_name] = descr; | ||
| descr_cache[doc_class_name][signal_name] = descr; |
There was a problem hiding this comment.
The cache is not invalidated until the editor is restarted. This is good for native classes, but bad for scripts. Perhaps we should not cache script signal descriptions?
We could also move the loop outside to prevent unnecessary iterations (actually, this is not so important since a class usually has few signals).
There was a problem hiding this comment.
I guess not caching script signal descriptions might be fine, provided that it's not too costly to recompute each time.
Otherwise they could be cached separately, and the script cache entry marked dirty whenever the script changes.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
