Check if any global script class is shadowed by a variable

[garychia]

Related to #80003

• Bugsquad edit, fixes: Variable name shadowing class_name class doesn't trigger any error/warning #80003

[anvilfolk]

Looks great to me! Make sure to use keywords that github understands, like directly say Fixes #<pr-number>, which will autolink it :)

[dalexeev]

I haven't tested, just guessing. Can you get a false positive warning when reloading the script in the editor if the class name is already in the global script cache?

[anvilfolk]

Oh, good point. Let me try.

[anvilfolk]

I couldn't get the warning to fire when it shouldn't. This is an easy one to revert should problems crop up, so I'd say I still want to merge!

However, I'd actually like to see improved error handling, like so:

1. The current warning should explicitly say it's a native class, because I think what ClassDB contains?
2. We should add another case for the GDScript/scriptserver warning, which should also actually expose what file the class is defined in using ScriptServer::get_global_class_path(class_name). That way we easily know where the conflict is coming from!

[anvilfolk]

Also, I notice you have quite a few PRs but often say related to instead of fixes/closes in them - feel free to edit those so that GH actually links the issues!

And you'd be very welcome in the Godot contributors chat if you wanted to discuss stuff with other godot devs!

[anvilfolk]

Just a small change more so the code is consistent, then I think it's good to merge :)

[anvilfolk]

Looks great!!! :)

[akien-mga]

Thanks!