-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bitmap fonts] Add support for scaling. #80605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Needs rebase.
Poke :) |
b7027c8
to
21b6773
Compare
21b6773
to
9a1e0e4
Compare
Thanks! |
Great work! I don't think the default scaling configuration is correct though because my pixel art fonts all became very large. This is due to the default font size that is set in the theme (I think it is 16) and that setting used to be ignored. |
@sandord I suppose this means there's a small degree of compatibility breakage with this PR, but I think the new default behavior is what 99% of people expect when changing font size on a bitmap font (unless there is special casing that makes it ignore a non-overridden font size – I didn't test). So I'd prefer keeping the default to Enabled (Fractional).1 On the other hand, this approach is contrary to what this comment suggests. cc @bruvzg @rakkarage Please open a separate issue with a minimal reproduction project attached. Footnotes
|
Adds import option for the bitmap fonts to enable scaling support (integer or arbitrary).
Fixes #80497
Fixes godotengine/godot-proposals#6150