Fix particle shader deterministic random values #80638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:4.1
|
There are more cases in the same file just a few lines down |
sepTN
force-pushed
the
fix-particle-shader-rand
branch
from
bc1a9c9 to
318ae99
Compare
sepTN
force-pushed
the
fix-particle-shader-rand
branch
from
a7df458 to
cb7400d
Compare
|
LGTM, could you take a look at #79527 ? Once that is merged this PR will be overridden by those changes and I'd like to make sure that it does not re-introduce any regression. It should not be an issue since all random values are calculated and stored at the beginning of the function, but i'd be happy to have a second pair of eye on it ^^ |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80625
bugsquad edit: Fixes #78771