GLTF: Move unique name generation code to GLTFState #80803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
gltf-gen-unique-name
branch
from
0c7f2b9 to
0b92b5d
Compare
aaronfranke
changed the title
|
@lyuma mentioned some comments on this |
aaronfranke
force-pushed
the
gltf-gen-unique-name
branch
from
0b92b5d to
0a5ee61
Compare
aaronfranke
force-pushed
the
gltf-gen-unique-name
branch
from
0a5ee61 to
39232b8
Compare
aaronfranke
force-pushed
the
gltf-gen-unique-name
branch
from
39232b8 to
c1ec83b
Compare
|
I have no strong opinion either way, but this seems to introduce an inconsistency with other similar helper methods: String _gen_unique_animation_name(Ref<GLTFState> p_state, const String &p_name);
String _gen_unique_bone_name(Ref<GLTFState> p_state, const GLTFSkeletonIndex p_skel_i, const String &p_name); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
_gen_unique_namemethod from GLTFDocument into GLTFState and renames it togenerate_unique_name. Without this PR, it is not possible for GLTFDocumentExtension classes to generate unique names, so it's not possible to provide the same uniqueness guarantee as GLTFDocument itself.This PR also cleans up the code a bit, replacing the
while (true)andbreak;code with a simpleforloop. I tested it and it functions exactly the same as before, just now the code is easier to read.Note: Per Lyuma's request, I have removed the exposing in this PR, so this PR is just moving the method and making it available to in-engine C++ code. We can expose it in a future PR.