-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading more DDS formats #81220
Support loading more DDS formats #81220
Conversation
b5674e4
to
da34fdb
Compare
da34fdb
to
79e0f52
Compare
79e0f52
to
3f234ee
Compare
I support this, but I haven't had the chance to review and test what happens when I give it dds that are currently unsupported but will be supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either that, or if it makes sense to keep the commits separate (which it could, first refactor, then add features), then this PR should be rebases on top of 80900 and kept as two commits, instead of squashed. |
3f234ee
to
7cf5d91
Compare
Looks like something went wrong when rebasing |
7cf5d91
to
3f234ee
Compare
ee06c18
to
d9f9da7
Compare
Now that #80900 has been merged, this just needs a rebase and we can merge it :) |
Also, in case you are interested, I ran into another unsupported format in the wild Renderdoc opens it as an A8_UNORM. To be clear, I am not requesting you add support for another format to this PR. |
For context:
|
I'll open another PR in the future with support for slightly less common formats such as this one. But on the topic of this format, what should Godot import it as? The engine doesn't support images with only the alpha channel, so should it be treated as l8 or l8a8 with fully black/white luminance channel? |
d9f9da7
to
c278cc3
Compare
I would think l8. As its half the size of l8a8 |
Thanks! |
Depends on #80900
Adds support for loading the following DDS formats:
An MRP containing DDS files encoded in these formats: DDSFormatsExtended.zip
Godot 4.2-dev3 is unable to load any of them correctly.