Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDExtension: fix bool unknown in C #81247

Merged
merged 1 commit into from
Sep 2, 2023
Merged

GDExtension: fix bool unknown in C #81247

merged 1 commit into from
Sep 2, 2023

Conversation

Bromeon
Copy link
Contributor

@Bromeon Bromeon commented Sep 2, 2023

Pull request #78634 added a method accepting bool instead of GDExtensionBool.
This does not compile under C.

@Bromeon Bromeon requested review from a team as code owners September 2, 2023 10:57
@Bromeon Bromeon mentioned this pull request Sep 2, 2023
Merged
@akien-mga akien-mga added this to the 4.2 milestone Sep 2, 2023
dsnopek
dsnopek approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! Sorry I missed that one in my review of the original PR

@dsnopek
Copy link
Contributor

dsnopek commented Sep 2, 2023

PR #81238 should fix the CI. If/when it's merged, this one will just need a rebase.

@Bromeon Bromeon force-pushed the bugfix/yet-another-bool branch from 2ab646d to 4e202bc Compare September 2, 2023 19:05
@Sauermann
Copy link
Contributor

Thank you for fixing this bug from my PR.

@Bromeon
Copy link
Contributor Author

Bromeon commented Sep 2, 2023

No worries, I also missed it during review 🙈

Rebased onto master.

@akien-mga akien-mga merged commit 3f3f865 into godotengine:master Sep 2, 2023
@akien-mga
Copy link
Member

Thanks!

@Bromeon Bromeon deleted the bugfix/yet-another-bool branch September 3, 2023 11:37
@Bromeon Bromeon mentioned this pull request Aug 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug topic:gdextension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Bromeon @dsnopek @Sauermann @akien-mga