Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update AABB get_support description #81249

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[docs] Update AABB get_support description #81249

merged 1 commit into from
Sep 21, 2023

Conversation

beyarkay
Copy link
Contributor

@beyarkay beyarkay commented Sep 2, 2023

This is a simple documentation edit. It updates the description of the get_support method in AABB to explain what a support point is.

@beyarkay beyarkay requested a review from a team as a code owner September 2, 2023 12:57
@AThousandShips AThousandShips added this to the 4.x milestone Sep 2, 2023
doc/classes/AABB.xml Outdated Show resolved Hide resolved
doc/classes/AABB.xml Outdated Show resolved Hide resolved
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The final step before merging is to squash all the commits together so that the whole PR only contains 1 big commit with all your changes. We like to merge one commit at a time to keep the git history clean and navigable.

If you don't know how to do that, we have a helpful tutorial in the official documentation https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase

@akien-mga akien-mga changed the title [docs] update AABB get_support description [docs] Update AABB get_support description Sep 5, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 5, 2023
This is a simple documentation edit. It updates the description of the
get_support method in AABB to explain what a support point is.
@beyarkay
Copy link
Contributor Author

Apologies for the delay, I've squashed all commits

@beyarkay
Copy link
Contributor Author

Just want to check about what the process is here, or what boxes need to be checked before this can be merged? Thanks! I'm sure you're all super busy with the Unity refugees so I really appreciate the time (:

@akien-mga
Copy link
Member

You don't need to do anything further, once approved it's ready to merge by the production team, when we get to it.

@akien-mga akien-mga merged commit 1094239 into godotengine:master Sep 21, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@beyarkay beyarkay deleted the patch-1 branch September 21, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants