Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump Emscripten version to 3.1.36 #81329

Closed

Conversation

akien-mga
Copy link
Member

That's the last working version for LTO builds based on #80010, but aside from this we should be able to upgrade.

This goes together with godotengine/build-containers#128 which updates the version used for official builds similarly. For now I'm only planning to use those containers for 4.2+, so this shouldn't be cherry-picked.

That's the last working version for LTO builds based on godotengine#80010,
but aside from this we should be able to upgrade.
@akien-mga akien-mga added this to the 4.2 milestone Sep 5, 2023
@akien-mga akien-mga requested a review from a team as a code owner September 5, 2023 07:23
@akien-mga akien-mga requested a review from a team September 5, 2023 07:23
@akien-mga
Copy link
Member Author

I need to double check whether 3.1.37 is really the first regressing version. All upstream reports point to 3.1.42, so this was maybe wrongly identified in #80010.

@akien-mga
Copy link
Member Author

Seems like we could go all the way to 3.1.41, but also beyond with a workaround: #80010 (comment)

I'll work on that and make another PR.

@akien-mga akien-mga closed this Sep 5, 2023
@AThousandShips AThousandShips removed this from the 4.2 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants