Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] mbedtls: Fix UWP arm32 build after 2.28.3 enabled AES-NI intrinsics on MSVC #81401

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Sep 7, 2023

I'll make a PR to master as this might be relevant for Windows "Win32" ARM and ARM64 builds too.

Upstream bug report: Mbed-TLS/mbedtls#8168

@akien-mga akien-mga added bug platform:windows platform:uwp topic:thirdparty cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Sep 7, 2023
@akien-mga akien-mga added this to the 3.6 milestone Sep 7, 2023
@akien-mga akien-mga marked this pull request as ready for review September 7, 2023 08:53
@akien-mga akien-mga requested a review from a team as a code owner September 7, 2023 08:53
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but makes sense and looks good.

@akien-mga akien-mga merged commit 9434c69 into godotengine:3.x Sep 7, 2023
@akien-mga akien-mga deleted the mbedtls-fix-uwp-arm branch September 7, 2023 11:33
@akien-mga
Copy link
Member Author

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants