Fix subpixel layouts in text rendering

[0xafbf]

The RGB subpixel layout configuration was actually doing subpixel rendering for the BGR layout.

[YuriSizov]

@0xafbf Sorry for not getting back earlier. Could you demonstrate the difference? It looks like a typo, but it's hard to say if the output looks as expected or not with or without these changes.

[0xafbf]

In the screenshot you share, look how the red subpixel gets lit when the blue one should be lit, and it is unlit when the blue one should be unlit

That screenshot doesn't seem to use a uniform rgb layout though, give me a second and I'll post another picture.

[bruvzg]

In the screenshot you share, look how the red subpixel gets lit when the blue one should be lit, and it is unlit when the blue one should be unlit

Yes, you are probably right, and tint is likely chromatic aberration from the lens. After looking at a different angle and closer distance (can take a photo in this position) it looks more correct with the changed order.

Edit: rendering with the filliped order also matches sample RGB subpixel AA images.

[0xafbf]

I already had the picture when I saw you already commented. I'm posting it for reference. Left is previous, right is with PR fix:

Picture quality is not the greatest, because I was taking photo from microscope screen. The change is the most noticeable with text with lines of a single pixel width.

[akien-mga]

Thanks!