Add unit test for IP.resolve_hostname
#81465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RevoluPowered
force-pushed
the
unit-test-resolve-hostname
branch
from
7855c08
to
e63635c
Compare
akien-mga
changed the title
IP.resolve_hostname
akien-mga
force-pushed
the
unit-test-resolve-hostname
branch
from
e63635c
to
65d076b
Compare
|
Thanks! |
|
I just realized this test was meant to reproduce a bug that's apparently not fixed yet. So if it actually succeeds in triggering a bug, it means we'd have a broken test suite now. So far it doesn't seem to have triggered it but this should be looked into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reproduce the bug we found here:
#80727