Supplement the case of scene instantiation for "Editable Children" #81530
Conversation
Rindbee
force-pushed
the
supplement-scene-instantiation-for-editable-children
branch
from
e5d0d2e to
cea3ff6
Compare
|
What does it fix exactly? |
Rindbee
force-pushed
the
supplement-scene-instantiation-for-editable-children
branch
from
cea3ff6 to
216ec91
Compare
|
When Editable Children is enabled, due to copying nodes or specifying the same resource instance for different nodes in batches, the same resource entries will be recorded when saving. When opened again, resources with A test project is provided here. Before opening the scene, please check the text of 0.mp4 |
Rindbee
force-pushed
the
supplement-scene-instantiation-for-editable-children
branch
from
216ec91 to
f7d0c23
Compare
|
In the case in #81530 (comment), there may be multiple resource instances with the same |
This is a follow-up to godotengine#65011. For scenes with **Editable Children** enabled, the main scene will record more information and resource mapping will be valid for multiple nodes.
Rindbee
force-pushed
the
supplement-scene-instantiation-for-editable-children
branch
from
f7d0c23 to
439317f
Compare
| @@ -161,6 +172,7 @@ Node *SceneState::instantiate(GenEditState p_edit_state) const { | |||
| bool gen_node_path_cache = p_edit_state != GEN_EDIT_STATE_DISABLED && node_path_cache.is_empty(); | |||
|
|
|||
| HashMap<Ref<Resource>, Ref<Resource>> resources_local_to_scene; | |||
| HashMap<Node *, HashMap<Ref<Resource>, Ref<Resource>>> resources_local_to_sub_scene; // Record the mappings in sub-scenes. | |||
There was a problem hiding this comment.
Do we want to create typedefs for these types, they're very cumbersome
There was a problem hiding this comment.
We rarely use typedefs, especially for cases like this.
|
PackedScene changes at this stage seem risky (4.2 RC imminent), so moving to the next milestone. |
This is a follow-up to #65011.
For scenes with Editable Children enabled, the main scene will record more information and resource mapping will be valid for multiple nodes. See #64487 (comment).