Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR: Fix error spam if session hasn't started yet #81536

Merged

Conversation

BastiaanOlij
Copy link
Contributor

Some of the XR runtimes (like Meta Quest over link) may not set the session state to ready until the user puts on their headset. This was leading to a lot of error spam in the logs.

This PR fixes that by not reporting errors for the session not having been set to the running state.

@BastiaanOlij BastiaanOlij added this to the 4.2 milestone Sep 11, 2023
@BastiaanOlij BastiaanOlij self-assigned this Sep 11, 2023
@BastiaanOlij BastiaanOlij requested a review from m4gr3d September 11, 2023 04:32
@BastiaanOlij BastiaanOlij marked this pull request as ready for review September 11, 2023 05:21
@akien-mga akien-mga changed the title OpenXR fix error spam if session hasn't started yet OpenXR: Fix error spam if session hasn't started yet Sep 11, 2023
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@YuriSizov YuriSizov merged commit ded1393 into godotengine:master Sep 14, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_openxr_not_running_error_spam branch October 5, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants