Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the equality check for TabBar.set_tab_metadata #81648

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Remove the equality check for TabBar.set_tab_metadata #81648

merged 1 commit into from
Oct 2, 2023

Conversation

4d49
Copy link
Contributor

@4d49 4d49 commented Sep 14, 2023

Makes the code equivalent to the Tree.set_metadata code.

Fix: #81647

@4d49
Removes the equality check for set_tab_metadata
4982bec 
Makes the code equivalent to the `Tree.set_metadata` code.

Fix: godotengine#81647
@4d49 4d49 requested a review from a team as a code owner September 14, 2023 13:09
@4d49 4d49 changed the title Removes the equality check for set_tab_metadata Removes the equality check for TabBar.set_tab_metadata Sep 14, 2023
@Chaosus Chaosus added this to the 4.2 milestone Sep 14, 2023
@YuriSizov YuriSizov changed the title Removes the equality check for TabBar.set_tab_metadata Remove the equality check for TabBar.set_tab_metadata Sep 14, 2023
KoBeWi
KoBeWi approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency aside, while we tend to do early returns in setters, this one has no side-effects and is cheap, so the condition is kind of pointless.

@akien-mga akien-mga merged commit 0d03444 into godotengine:master Oct 2, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@4d49 4d49 deleted the fix-tab-metadata branch October 3, 2023 04:19
4d49 added a commit to 4d49/scene-library that referenced this pull request Oct 24, 2023
@4d49
Remove fix
39e3058 
Fixed: godotengine/godot#81648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@YeldhamDev YeldhamDev YeldhamDev approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

TabBar metadata is not reassigned if the data is an empty Array or Dictionary
5 participants
@4d49 @akien-mga @KoBeWi @YeldhamDev @Chaosus