GDScript: Fix POT generator crash on assignee with index #81653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dalexeev
commented
Sep 14, 2023
dalexeev
commented
- Closes Crash on 'Generate POT' when Dictionary-modifying Method is Present #79697.
dalexeev
added
bug
topic:gdscript
topic:editor
crash
cherrypick:4.1
akien-mga
approved these changes
Sep 14, 2023
anvilfolk
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
This is also how I was looking at the fix, and I can confirm from my own testing that the approach does work.
Like we discussed there are probably some further improvements possible with making the subscripts check recursive, in case we have something like base.index1.index2["index3"] or something like it... but this way it won't crash :)
|
Note: This may be a non-trivial to cherry-pick for 4.1, since #80020 was merged into 4.2 (not into 4.1 as I thought). |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Can't cherry-pick cleanly because it depends on #80020. I would appreciate a dedicated PR for 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.