Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7213 - Add basic 'Game' button in editor plugins #81825

Conversation

ShlomiRex
Copy link
Contributor

@ShlomiRex ShlomiRex commented Sep 17, 2023

This is one commit which should incrementaly fix: godotengine/godot-proposals#7213

Adds 'Game' in the editor.
The buttons will show: "2D", "3D", "Script", "Game", "AssetLib" (in this order).

Untitled

Adds 'Game' in the editor.
The buttons will show: "2D", "3D", "Script", "Game", "AssetLib" (in this order).
@AThousandShips
Copy link
Member

Is this meant to be a draft? It does not implement the proposal

@ShlomiRex
Copy link
Contributor Author

Is this meant to be a draft? It does not implement the proposal

Can you elaborate?

@AThousandShips
Copy link
Member

AThousandShips commented Sep 17, 2023

This doesn't allow you to run the game in the editor interface, it just adds a tab named "Game" that doesn't do anything?

@ShlomiRex
Copy link
Contributor Author

This doesn't allow you to run the game in the editor interface, it just adds a tab named "Game" that doesn't do anything?

The tab isn't even added by this case

I do incremental steps to implement the feature.
I don't implement a feature in a single commit, I strech it.

@AThousandShips
Copy link
Member

That won't be accepted, adding a non-functuonal component doesn't make sense

What do you mean by "stretch it"?

@ShlomiRex
Copy link
Contributor Author

That won't be accepted, adding a non-functuonal component doesn't make sense

What do you mean by "stretch it"?

What do you suggest?

@ShlomiRex ShlomiRex closed this Sep 17, 2023
@AThousandShips
Copy link
Member

What I suggest? To make one PR that implements a complete feature, that makes the most sense no?

@AThousandShips
Copy link
Member

I'm still a bit confused what you mean by this:

I don't implement a feature in a single commit, I strech it.

@jcostello
Copy link
Contributor

@ShlomiRex what @AThousandShips is saying is that, if this PR is a work in progress, you should tag it as DRAFT (in the title and label). A PR should be something almost ready to merge with a complete functionality to review. I suggest you to open a PR when its almost ready or the basic implementation ready.
If you need to ask questions about the design you can use the proposal you are working on

@AThousandShips
Copy link
Member

This PR was, according to the OP, the complete work they wanted to commit, to do the remaining steps later

@Zireael07
Copy link
Contributor

Yeah, and it makes no sense since to be merged the PR needs to have complete functionality. A single button which does nothing when clicked is NOT complete functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for embedding the game window in the editor
4 participants