-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7213 - Add basic 'Game' button in editor plugins #81825
Fix #7213 - Add basic 'Game' button in editor plugins #81825
Conversation
Adds 'Game' in the editor. The buttons will show: "2D", "3D", "Script", "Game", "AssetLib" (in this order).
Is this meant to be a draft? It does not implement the proposal |
Can you elaborate? |
This doesn't allow you to run the game in the editor interface, it just adds a tab named "Game" that doesn't do anything? |
I do incremental steps to implement the feature. |
That won't be accepted, adding a non-functuonal component doesn't make sense What do you mean by "stretch it"? |
What do you suggest? |
What I suggest? To make one PR that implements a complete feature, that makes the most sense no? |
I'm still a bit confused what you mean by this:
|
@ShlomiRex what @AThousandShips is saying is that, if this PR is a work in progress, you should tag it as DRAFT (in the title and label). A PR should be something almost ready to merge with a complete functionality to review. I suggest you to open a PR when its almost ready or the basic implementation ready. |
This PR was, according to the OP, the complete work they wanted to commit, to do the remaining steps later |
Yeah, and it makes no sense since to be merged the PR needs to have complete functionality. A single button which does nothing when clicked is NOT complete functionality |
This is one commit which should incrementaly fix: godotengine/godot-proposals#7213
Adds 'Game' in the editor.
The buttons will show: "2D", "3D", "Script", "Game", "AssetLib" (in this order).